fix: remove map iteration non-determinism with keys #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkxkd0159
requested review from
zemyblue,
0Tech and
jaeseung-bae
as code owners
tkxkd0159
added
A: bug
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1302 +/- ##
=======================================
Coverage 70.42% 70.43%
=======================================
Files 643 643
Lines 54702 54720 +18
=======================================
+ Hits 38526 38542 +16
- Misses 14006 14008 +2
Partials 2170 2170
|
0Tech
approved these changes
Mar 26, 2024
jaeseung-bae
approved these changes
Mar 26, 2024
mergify bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
* remove map iteration non-determinism with keys * add CHANGELOG (cherry picked from commit c462f36) # Conflicts: # CHANGELOG.md
5 tasks
0Tech
added a commit
that referenced
this pull request
Mar 29, 2024
…1305) * fix: remove map iteration non-determinism with keys (#1302) * remove map iteration non-determinism with keys * add CHANGELOG (cherry picked from commit c462f36) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Jayden Lee <[email protected]> Co-authored-by: Youngtaek Yoon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
ref. cosmos/cosmos-sdk#13377
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml